Skip to content

fix: add freemarker new plugin to idf.target#871

Merged
kolipakakondal merged 1 commit intomasterfrom
freemarker_fix
Dec 14, 2023
Merged

fix: add freemarker new plugin to idf.target#871
kolipakakondal merged 1 commit intomasterfrom
freemarker_fix

Conversation

@kolipakakondal
Copy link
Copy Markdown
Collaborator

@kolipakakondal kolipakakondal commented Dec 14, 2023 •
edited
Loading

Description

idf.target is not resolving org.freemarker.freemarker plugin.

Fixes # (IEP-XXX)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Test 1:
Espressif-IDE v2.11.1+ PR Update site > Install Tools > Create a new project
Test 2:
Eclipse CDT 2023-09 + PR Update site > Install Tools > Create a new project

Test Configuration:

  • ESP-IDF Version:master
  • OS (Windows,Linux and macOS):macOS

Dependent components impacted by this PR:

  • Update site

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Refactor
    • Improved XML configuration formatting for better readability and consistency.
  • New Features
    • Integrated new Maven dependency for ASM within the project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 14, 2023 •
edited
Loading

Walkthrough

The changes involve updates to an XML configuration file for the Espressif IDF target within a release engineering project. The modifications include a cleanup of the version format in <unit> tags and the addition of a new Maven dependency for ASM within a <location> element. There are no alterations to any exported or public entities, indicating that the changes are confined to configuration management.

Changes

File Path Change Summary
releng/.../com.espressif.idf.target.target Reformatted version attributes in <unit> tags; Added new <location> for ASM Maven dependency

🐇✨
In the realm of code, where the data streams flow,
A tidy-up here, a new line in tow.
As the XML blooms, with tags so precise,
The rabbit's work done, all neat and nice. 🌟📝

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

coderabbitai[bot]
coderabbitai bot reviewed Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c5c998f and d04e644.
Files selected for processing (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target (2 hunks)
Files skipped from review due to trivial changes (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target

alirana01
alirana01 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alirana01 alirana01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and this fixes the issue with target selection

@kolipakakondal kolipakakondal merged commit 712d7a7 into master Dec 14, 2023
@kolipakakondal kolipakakondal deleted the freemarker_fix branch December 14, 2023 11:25
@kolipakakondal kolipakakondal added this to the v2.12.0 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@alirana01 alirana01 alirana01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kolipakakondal @alirana01